Skip to content

[ISSUE #9279] Restrict system subscription group creation and add pull request rejection policy#9280

Merged
lizhimins merged 1 commit intoapache:developfrom
ymwneu:rejectPullConsumer
Apr 1, 2025
Merged

[ISSUE #9279] Restrict system subscription group creation and add pull request rejection policy#9280
lizhimins merged 1 commit intoapache:developfrom
ymwneu:rejectPullConsumer

Conversation

@ymwneu
Copy link
Copy Markdown
Contributor

@ymwneu ymwneu commented Mar 27, 2025

…l consumer when pullmessage

Which Issue(s) This PR Fixes

Fixes #9279

Brief Description

  1. When the "rejectPullConsumerEnable" configuration is enabled, restrict pull requests when pulling messages.
  2. Automatic creation and addition of switch recognition for subscription groups to prevent abuse of system subscriptions.

How Did You Test This Change?

@ymwneu ymwneu changed the title [ISSUE #9279]1. control sysGroup create; 2. if rejectPullConsumerEnable reject pull [ISSUE #9279]1. control sysGroup create; 2. if rejectPullConsumerEnable reject pull request Mar 27, 2025
@ymwneu ymwneu changed the title [ISSUE #9279]1. control sysGroup create; 2. if rejectPullConsumerEnable reject pull request [ISSUE #9279] Restrict system subscription group creation and add pull request rejection policy Mar 27, 2025
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Mar 27, 2025

Codecov Report

❌ Patch coverage is 11.11111% with 16 lines in your changes missing coverage. Please review.
✅ Project coverage is 48.02%. Comparing base (729275c) to head (0524a32).
⚠️ Report is 292 commits behind head on develop.

Files with missing lines Patch % Lines
...ocketmq/broker/processor/PullMessageProcessor.java 0.00% 8 Missing and 1 partial ⚠️
.../java/org/apache/rocketmq/common/BrokerConfig.java 25.00% 3 Missing ⚠️
.../rocketmq/broker/coldctr/ColdDataCgCtrService.java 0.00% 1 Missing ⚠️
.../broker/subscription/SubscriptionGroupManager.java 50.00% 0 Missing and 1 partial ⚠️
...c/main/java/org/apache/rocketmq/common/MixAll.java 0.00% 1 Missing ⚠️
...org/apache/rocketmq/store/DefaultMessageStore.java 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #9280      +/-   ##
=============================================
- Coverage      48.13%   48.02%   -0.11%     
+ Complexity     12124    12098      -26     
=============================================
  Files           1322     1322              
  Lines          93139    93154      +15     
  Branches       11943    11948       +5     
=============================================
- Hits           44832    44739      -93     
- Misses         42776    42867      +91     
- Partials        5531     5548      +17     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@lizhimins lizhimins merged commit 586a274 into apache:develop Apr 1, 2025
10 of 11 checks passed
3424672656 pushed a commit to 3424672656/rocketmq that referenced this pull request May 12, 2025
RongtongJin pushed a commit that referenced this pull request Jul 19, 2025
ChineseTony pushed a commit to ChineseTony/rocketmq that referenced this pull request Aug 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Enhancement] Restrict system subscription group creation and add pull request rejection policy

4 participants