Skip to content

[ISSUE #9288]To prevent an excessive amount of PID data, support disabling producer registration.#9289

Closed
ymwneu wants to merge 2 commits intoapache:developfrom
ymwneu:registerProducer
Closed

[ISSUE #9288]To prevent an excessive amount of PID data, support disabling producer registration.#9289
ymwneu wants to merge 2 commits intoapache:developfrom
ymwneu:registerProducer

Conversation

@ymwneu
Copy link
Copy Markdown
Contributor

@ymwneu ymwneu commented Mar 28, 2025

Which Issue(s) This PR Fixes

Fixes #9288

Brief Description

The current broker retains all producer channel information, which can consume a significant amount of resources when there are a large number of producers. In non-transactional message scenarios, the producer channel information is not useful. It would be beneficial to consider adding a switch to not record PID information in these scenarios.

How Did You Test This Change?

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Mar 28, 2025

Codecov Report

❌ Patch coverage is 53.84615% with 12 lines in your changes missing coverage. Please review.
✅ Project coverage is 48.06%. Comparing base (729275c) to head (301cdb2).
⚠️ Report is 288 commits behind head on develop.

Files with missing lines Patch % Lines
...apache/rocketmq/broker/client/ProducerManager.java 59.09% 4 Missing and 5 partials ⚠️
.../java/org/apache/rocketmq/common/BrokerConfig.java 25.00% 3 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #9289      +/-   ##
=============================================
- Coverage      48.13%   48.06%   -0.07%     
+ Complexity     12124    12102      -22     
=============================================
  Files           1322     1322              
  Lines          93139    93165      +26     
  Branches       11943    11951       +8     
=============================================
- Hits           44832    44780      -52     
- Misses         42776    42836      +60     
- Partials        5531     5549      +18     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ymwneu ymwneu closed this Mar 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Enhancement] Support the disablement of producer registration and fast channel shutdown.

3 participants