Skip to content

[ISSUE #9297] Supports outputting topic put TPS in TopicStatusSubCommand#9298

Merged
lizhimins merged 2 commits intoapache:developfrom
ymwneu:topicStatusSupportTPS
Apr 2, 2025
Merged

[ISSUE #9297] Supports outputting topic put TPS in TopicStatusSubCommand#9298
lizhimins merged 2 commits intoapache:developfrom
ymwneu:topicStatusSupportTPS

Conversation

@ymwneu
Copy link
Copy Markdown
Contributor

@ymwneu ymwneu commented Mar 31, 2025

Which Issue(s) This PR Fixes

Fixes #9297

Brief Description

The server currently collects statistics on the topic put TPS, but this information isn’t available through the command line tool. It is recommended to add it to TopicStatusSubCommand by introducing a new display of the topic TPS information for users to view.

How Did You Test This Change?

@lizhimins
Copy link
Copy Markdown
Member

Error: /home/runner/work/rocketmq/rocketmq/store/src/main/java/org/apache/rocketmq/store/stats/BrokerStatsManager.java:584:54: '{' is not preceded with whitespace. [WhitespaceAround]

@lizhimins lizhimins changed the title [ISSUE #9297]TopicStatusSubCommand supports outputting topic put TPS. [ISSUE #9297] TopicStatusSubCommand supports outputting topic put TPS. Apr 1, 2025
@lizhimins lizhimins changed the title [ISSUE #9297] TopicStatusSubCommand supports outputting topic put TPS. [ISSUE #9297] Supports outputting topic put TPS in TopicStatusSubCommand Apr 1, 2025
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Apr 1, 2025

Codecov Report

❌ Patch coverage is 50.00000% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 48.03%. Comparing base (729275c) to head (f112f3f).
⚠️ Report is 292 commits behind head on develop.

Files with missing lines Patch % Lines
...pache/rocketmq/store/stats/BrokerStatsManager.java 33.33% 1 Missing and 1 partial ⚠️
...tmq/tools/command/topic/TopicStatusSubCommand.java 0.00% 2 Missing ⚠️
...he/rocketmq/tools/admin/DefaultMQAdminExtImpl.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #9298      +/-   ##
=============================================
- Coverage      48.13%   48.03%   -0.11%     
+ Complexity     12124    12112      -12     
=============================================
  Files           1322     1322              
  Lines          93139    93230      +91     
  Branches       11943    11952       +9     
=============================================
- Hits           44832    44782      -50     
- Misses         42776    42901     +125     
- Partials        5531     5547      +16     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@lizhimins lizhimins merged commit d5b474d into apache:develop Apr 2, 2025
10 of 11 checks passed
3424672656 pushed a commit to 3424672656/rocketmq that referenced this pull request May 12, 2025
ChineseTony pushed a commit to ChineseTony/rocketmq that referenced this pull request Aug 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Enhancement] TopicStatusSubCommand supports outputting topic put TPS

5 participants