Skip to content

[ISSUE #9302] SendMessageContext add message type#9303

Merged
lizhimins merged 1 commit intoapache:developfrom
ymwneu:messageType
Apr 9, 2025
Merged

[ISSUE #9302] SendMessageContext add message type#9303
lizhimins merged 1 commit intoapache:developfrom
ymwneu:messageType

Conversation

@ymwneu
Copy link
Copy Markdown
Contributor

@ymwneu ymwneu commented Mar 31, 2025

Which Issue(s) This PR Fixes

Fixes #9302

Brief Description

Currently, when setting msgType in SendMessageContext, only normal messages and ordered messages are distinguished. Transactional messages and delayed messages are not differentiated.
In subsequent implementations of the send message hook, it won't be possible to differentiate the actual message type.

How Did You Test This Change?

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Mar 31, 2025

Codecov Report

❌ Patch coverage is 28.57143% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 48.02%. Comparing base (729275c) to head (f89a44b).
⚠️ Report is 286 commits behind head on develop.

Files with missing lines Patch % Lines
...broker/processor/AbstractSendMessageProcessor.java 28.57% 1 Missing and 4 partials ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #9303      +/-   ##
=============================================
- Coverage      48.13%   48.02%   -0.12%     
+ Complexity     12124    12100      -24     
=============================================
  Files           1322     1322              
  Lines          93139    93152      +13     
  Branches       11943    11948       +5     
=============================================
- Hits           44832    44735      -97     
- Misses         42776    42868      +92     
- Partials        5531     5549      +18     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@lizhimins lizhimins changed the title [ISSUE #9302] SendMessageContext adds a new message type [ISSUE #9302] SendMessageContext add message type Apr 9, 2025
@lizhimins lizhimins merged commit 689c1ec into apache:develop Apr 9, 2025
10 of 11 checks passed
3424672656 pushed a commit to 3424672656/rocketmq that referenced this pull request May 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Enhancement] SendMessageContext adds a new message type.

5 participants