Skip to content

[ISSUE #9304] Resolve cold data read control issue in DefaultMessageStore#9305

Merged
lizhimins merged 1 commit intoapache:developfrom
ymwneu:codeReadBugFix
Apr 1, 2025
Merged

[ISSUE #9304] Resolve cold data read control issue in DefaultMessageStore#9305
lizhimins merged 1 commit intoapache:developfrom
ymwneu:codeReadBugFix

Conversation

@ymwneu
Copy link
Copy Markdown
Contributor

@ymwneu ymwneu commented Mar 31, 2025

Which Issue(s) This PR Fixes

Fixes #9304

Brief Description

In the ColdDataCheckService#isMsgInColdArea() method, when forcibly casting the consume queue to ConsumeQueue, an error will be thrown if its type is not ConsumeQueue.

How Did You Test This Change?

@lizhimins lizhimins changed the title [ISSUE #9304] Code read control related bug fix. [ISSUE #9304] Resolve Code Read Control Issue in DefaultMessageStore Apr 1, 2025
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Apr 1, 2025

Codecov Report

❌ Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 48.05%. Comparing base (729275c) to head (1efc9f3).
⚠️ Report is 290 commits behind head on develop.

Files with missing lines Patch % Lines
...main/java/org/apache/rocketmq/store/CommitLog.java 0.00% 4 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #9305      +/-   ##
=============================================
- Coverage      48.13%   48.05%   -0.08%     
+ Complexity     12124    12105      -19     
=============================================
  Files           1322     1322              
  Lines          93139    93144       +5     
  Branches       11943    11943              
=============================================
- Hits           44832    44765      -67     
- Misses         42776    42832      +56     
- Partials        5531     5547      +16     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@lizhimins lizhimins changed the title [ISSUE #9304] Resolve Code Read Control Issue in DefaultMessageStore [ISSUE #9304] Resolve cold data read control issue in DefaultMessageStore Apr 1, 2025
@lizhimins lizhimins merged commit c5be5c8 into apache:develop Apr 1, 2025
10 of 11 checks passed
3424672656 pushed a commit to 3424672656/rocketmq that referenced this pull request May 12, 2025
ChineseTony pushed a commit to ChineseTony/rocketmq that referenced this pull request Aug 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] Code read control related bug fix.

4 participants