Avoid NPE for handling client settings null in notifyClientTermination#9308
Merged
lollipopjin merged 1 commit intoapache:developfrom Apr 2, 2025
Merged
Avoid NPE for handling client settings null in notifyClientTermination#9308lollipopjin merged 1 commit intoapache:developfrom
lollipopjin merged 1 commit intoapache:developfrom
Conversation
notifyClientTermination.
lizhimins
approved these changes
Apr 2, 2025
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #9308 +/- ##
=============================================
- Coverage 48.12% 48.06% -0.06%
+ Complexity 12140 12118 -22
=============================================
Files 1322 1322
Lines 93237 93242 +5
Branches 11957 11958 +1
=============================================
- Hits 44868 44816 -52
- Misses 42830 42881 +51
- Partials 5539 5545 +6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
3424672656
pushed a commit
to 3424672656/rocketmq
that referenced
this pull request
May 12, 2025
RongtongJin
pushed a commit
that referenced
this pull request
Jul 19, 2025
ChineseTony
pushed a commit
to ChineseTony/rocketmq
that referenced
this pull request
Aug 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which Issue(s) This PR Fixes
Avoid NPE for handling client settings null in notifyClientTermination