Skip to content

[ISSUE #9339] Fix pop update consumption offset when message are filtered#9340

Merged
lizhimins merged 1 commit intoapache:developfrom
lizhimins:issue-9339
Apr 16, 2025
Merged

[ISSUE #9339] Fix pop update consumption offset when message are filtered#9340
lizhimins merged 1 commit intoapache:developfrom
lizhimins:issue-9339

Conversation

@lizhimins
Copy link
Copy Markdown
Member

Which Issue(s) This PR Fixes

Fixes #9339

Brief Description

How Did You Test This Change?

Copy link
Copy Markdown
Contributor

@lollipopjin lollipopjin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Apr 16, 2025

Codecov Report

❌ Patch coverage is 54.54545% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 47.97%. Comparing base (775eb64) to head (6992234).
⚠️ Report is 108 commits behind head on develop.

Files with missing lines Patch % Lines
...apache/rocketmq/broker/pop/PopConsumerService.java 62.50% 2 Missing and 1 partial ⚠️
...rocketmq/broker/processor/PopMessageProcessor.java 0.00% 2 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #9340      +/-   ##
=============================================
- Coverage      48.02%   47.97%   -0.05%     
+ Complexity     12135    12125      -10     
=============================================
  Files           1323     1323              
  Lines          93394    93397       +3     
  Branches       11996    11997       +1     
=============================================
- Hits           44850    44806      -44     
- Misses         42992    43034      +42     
- Partials        5552     5557       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@lizhimins lizhimins merged commit 854369a into apache:develop Apr 16, 2025
10 of 11 checks passed
3424672656 pushed a commit to 3424672656/rocketmq that referenced this pull request May 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] Fix pop update consumption offset when message are filtered

3 participants