fix: listacl typo. resolves @issue9345#9346
Open
zhjuzi wants to merge 1 commit intoapache:developfrom
Open
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #9346 +/- ##
=============================================
- Coverage 48.04% 48.00% -0.05%
+ Complexity 12142 12123 -19
=============================================
Files 1323 1323
Lines 93395 93395
Branches 11997 11997
=============================================
- Hits 44875 44836 -39
- Misses 42971 42993 +22
- Partials 5549 5566 +17 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
yx9o
reviewed
Apr 21, 2025
| options.addOption(opt); | ||
|
|
||
| opt = new Option("r", "resource", true, "the resource of acl to filter."); | ||
| opt = new Option("r", "resource", true, "the resources of acl to filter."); |
Contributor
There was a problem hiding this comment.
From the code point of view, this is a single resource, so it should not be changed directly like this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR Fixes
Fixes #9345
Brief Description
This pull request fixes a typo in the option description of the ListAclSubCommand class.
Specifically, it changes "the resources of acl to filter." to use the correct word "resources" instead of the incorrect "resource" in the description for the -r/--resource option.
How Did You Test This Change?
This change only modifies a string in the command-line option description, so no functional code is affected.
I verified the change by reviewing the help output of the command to ensure the description now displays correctly.
No additional tests are required.