Skip to content

[ISSUE #9377]fix 'send trace data can fail if shutdown producer immediately'#9378

Merged
yuz10 merged 1 commit intoapache:developfrom
kingkh1995:fix_trace_send_failed
Apr 30, 2025
Merged

[ISSUE #9377]fix 'send trace data can fail if shutdown producer immediately'#9378
yuz10 merged 1 commit intoapache:developfrom
kingkh1995:fix_trace_send_failed

Conversation

@kingkh1995
Copy link
Copy Markdown
Contributor

Which Issue(s) This PR Fixes

Fixes #9377

Brief Description

  1. shutdown traceExecutor gracefully when shutdown AsyncTraceDispatcher;
  2. optimize flush(), no need to check size of appenderQueue, submitted tasks will be executed.

How Did You Test This Change?

test

@kingkh1995 kingkh1995 force-pushed the fix_trace_send_failed branch from b315168 to 8317860 Compare April 29, 2025 18:41
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Apr 29, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 48.11%. Comparing base (6819b4d) to head (8317860).
⚠️ Report is 266 commits behind head on develop.

Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #9378      +/-   ##
=============================================
- Coverage      48.15%   48.11%   -0.05%     
+ Complexity     12153    12142      -11     
=============================================
  Files           1323     1323              
  Lines          93441    93438       -3     
  Branches       12009    12007       -2     
=============================================
- Hits           44998    44954      -44     
- Misses         42878    42919      +41     
  Partials        5565     5565              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@kingkh1995
Copy link
Copy Markdown
Contributor Author

@yuz10

@yuz10 yuz10 merged commit c9deaa5 into apache:develop Apr 30, 2025
10 of 11 checks passed
3424672656 pushed a commit to 3424672656/rocketmq that referenced this pull request May 12, 2025
@kingkh1995 kingkh1995 deleted the fix_trace_send_failed branch May 13, 2025 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] send trace data can fail if shutdown producer immediately

3 participants