[ISSUE #9439] Add escape for win in the method returning broker configuration#9440
[ISSUE #9439] Add escape for win in the method returning broker configuration#9440RongtongJin merged 1 commit intoapache:developfrom
Conversation
RongtongJin
left a comment
There was a problem hiding this comment.
It is recommended to perform escaping on the client side (at the admin tools code), and handle it according to the platform type (can be done using MixAll.isWindows).
Thanks for the feedback! I've implemented the client-side escaping in the admin tools code as suggested. The logic now uses |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #9440 +/- ##
=============================================
+ Coverage 48.00% 48.04% +0.03%
- Complexity 11924 11984 +60
=============================================
Files 1307 1308 +1
Lines 92021 92174 +153
Branches 11775 11790 +15
=============================================
+ Hits 44177 44287 +110
- Misses 42368 42386 +18
- Partials 5476 5501 +25 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
934f67f to
9c0c436
Compare
Which Issue(s) This PR Fixes
Fixes #9439
Brief Description
utilize MixAll.isWindows for platform-specific escaping
Affected files:
MixAll.java: utilize MixAll.isWindows for platform-specific escapingHow Did You Test This Change?
The above is before the modification, you can see the bug. The following is after the modification, you can see the program returns normally.