Skip to content

[ISSUE #9471] load kv store before service start in PopConsumerService #9472

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
3424672656 wants to merge 2 commits into from
Closed

[ISSUE #9471] load kv store before service start in PopConsumerService #9472

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4947ff9
fix: load store before service start
Jun 13, 2025
c93c76f
Empty commit message
Jun 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions broker/src/main/java/org/apache/rocketmq/broker/BrokerController.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -883,6 +883,10 @@ public boolean recoverAndInitService() throws CloneNotSupportedException {
result = this.messageStore.load();
}

if (brokerConfig.isPopConsumerKVServiceInit()) {
result = result && popConsumerService.load();
Copy link
Copy Markdown
Member

@lizhimins lizhimins Jun 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

init method in BrokerController#startBasicService

Copy link
Copy Markdown
Contributor Author

@3424672656 3424672656 Jun 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clipboard_Screenshot_1750230321
init method in BrokerController#initialize

}

if (messageStoreConfig.isTimerWheelEnable()) {
result = result && this.timerMessageStore.load();
}
Expand Down
4 changes: 4 additions & 0 deletions broker/src/main/java/org/apache/rocketmq/broker/pop/PopConsumerKVStore.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,10 @@
import java.util.List;

public interface PopConsumerKVStore {
/**
* Load the kv store
*/
boolean load();

/**
* Starts the storage service.
Expand Down
5 changes: 5 additions & 0 deletions broker/src/main/java/org/apache/rocketmq/broker/pop/PopConsumerRocksdbStore.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,6 +103,11 @@ protected boolean postLoad() {
return true;
}

@Override
public boolean load() {
return start();
}

public String getFilePath() {
return this.dbPath;
}
Expand Down
4 changes: 4 additions & 0 deletions broker/src/main/java/org/apache/rocketmq/broker/pop/PopConsumerService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -692,6 +692,10 @@ public PopConsumerLockService getConsumerLockService() {
return consumerLockService;
}

public boolean load() {
return this.popConsumerStore.load();
}

@Override
public void start() {
if (!this.popConsumerStore.start()) {
Expand Down
Loading