[ISSUE #9422] Change default client instance name#9494
Closed
totalo wants to merge 13 commits intoapache:developfrom
Closed
[ISSUE #9422] Change default client instance name#9494totalo wants to merge 13 commits intoapache:developfrom
totalo wants to merge 13 commits intoapache:developfrom
Conversation
…iggered only in the official repository
build: Restrict the Snapshot Daily Release Automation action to be tr…
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #9494 +/- ##
=============================================
- Coverage 48.05% 48.03% -0.03%
- Complexity 12001 12043 +42
=============================================
Files 1308 1313 +5
Lines 92251 92763 +512
Branches 11808 11862 +54
=============================================
+ Hits 44334 44559 +225
- Misses 42430 42686 +256
- Partials 5487 5518 +31 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
lizhimins
requested changes
Jun 28, 2025
| public void changeInstanceNameToPIDWithGroupInfo(String groupInfo) { | ||
| if (this.instanceName.equals("DEFAULT")) { | ||
| this.instanceName = UtilAll.getPid() + "#" + System.nanoTime(); | ||
| this.instanceName = UtilAll.getPid() + "#" + groupInfo; |
Member
There was a problem hiding this comment.
Launching in a container environment would cause duplication here
lizhimins
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which Issue(s) This PR Fixes
Fixes #9422
Brief Description
How Did You Test This Change?