Skip to content

[ISSUE #9497] Fix IndexOutOfBoundsException in getEarliestMessageTime when running in IPv6 environment#9498

Merged
lizhimins merged 1 commit intoapache:developfrom
woaishixiaoxiao:fix/9497
Jun 30, 2025
Merged

[ISSUE #9497] Fix IndexOutOfBoundsException in getEarliestMessageTime when running in IPv6 environment#9498
lizhimins merged 1 commit intoapache:developfrom
woaishixiaoxiao:fix/9497

Conversation

@woaishixiaoxiao
Copy link
Copy Markdown
Contributor

@woaishixiaoxiao woaishixiaoxiao commented Jun 25, 2025

Which Issue(s) This PR Fixes

Fixes #9497

Brief Description

to solve getEarliestMessageTime throw expception problem in ipv6 env

How Did You Test This Change?

  1. in unit test, test various ipv6, like [2001:0db8:85a3:0000:0000:8a2e:0370:7334%eth0]
  2. test in ipv6 envirment and ipv4, no exception throw

@golden-yang
Copy link
Copy Markdown
Contributor

@lizhimins Excuse me, could you please take a look at this PR?

lizhimins
lizhimins previously approved these changes Jun 28, 2025
@lizhimins lizhimins changed the title [FIX #9497] getEarliestMessageTime throw indexOutOfBound exception [ISSUE #9497] Fix IndexOutOfBoundsException in getEarliestMessageTime when running in IPv6 environment Jun 28, 2025
@lizhimins
Copy link
Copy Markdown
Member

Error: /home/runner/work/rocketmq/rocketmq/store/src/main/java/org/apache/rocketmq/store/DefaultMessageStore.java:60:8: Unused import - org.apache.commons.validator.routines.InetAddressValidator. [UnusedImports]

@woaishixiaoxiao
Copy link
Copy Markdown
Contributor Author

Error: /home/runner/work/rocketmq/rocketmq/store/src/main/java/org/apache/rocketmq/store/DefaultMessageStore.java:60:8: Unused import - org.apache.commons.validator.routines.InetAddressValidator. [UnusedImports]

ok, i will corrected it.

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jun 30, 2025

Codecov Report

❌ Patch coverage is 63.63636% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 47.95%. Comparing base (c9ea749) to head (3da33b9).
⚠️ Report is 241 commits behind head on develop.

Files with missing lines Patch % Lines
.../org/apache/rocketmq/common/utils/NetworkUtil.java 63.63% 1 Missing and 3 partials ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #9498      +/-   ##
=============================================
- Coverage      47.96%   47.95%   -0.02%     
- Complexity     11908    11984      +76     
=============================================
  Files           1307     1309       +2     
  Lines          92021    92361     +340     
  Branches       11775    11817      +42     
=============================================
+ Hits           44139    44289     +150     
- Misses         42401    42562     +161     
- Partials        5481     5510      +29     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@lizhimins lizhimins merged commit 8956768 into apache:develop Jun 30, 2025
12 of 15 checks passed
WJ66880 pushed a commit to WJ66880/rocketmq that referenced this pull request Jul 1, 2025
…geTime when running in IPv6 environment (apache#9498)

Co-authored-by: shixiaoxiao <shixiaoxiao@bytedance.com>
hechen0 pushed a commit to hechen0/rocketmq that referenced this pull request Aug 18, 2025
…geTime when running in IPv6 environment (apache#9498)

Co-authored-by: shixiaoxiao <shixiaoxiao@bytedance.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] Bug title getEarliestMessageTime will throw java.lang.IndexOutOfBoundsException because of ipv6 only envirment

4 participants