[ISSUE 9535]: Prevent first message loss in CONSUME_FROM_LAST_OFFSET #7187#9552
Closed
mengnankkkk wants to merge 4 commits intoapache:developfrom
Closed
[ISSUE 9535]: Prevent first message loss in CONSUME_FROM_LAST_OFFSET
#7187#9552mengnankkkk wants to merge 4 commits intoapache:developfrom
mengnankkkk wants to merge 4 commits intoapache:developfrom
Conversation
…empty/single-message queues apache#9535
3 tasks
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #9552 +/- ##
=============================================
- Coverage 48.12% 48.00% -0.13%
+ Complexity 12067 12040 -27
=============================================
Files 1313 1313
Lines 92767 92770 +3
Branches 11862 11863 +1
=============================================
- Hits 44647 44530 -117
- Misses 42625 42728 +103
- Partials 5495 5512 +17 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…empty/single-message queues #9535
Which Issue(s) This PR Fixes
When maxOffset <= 1, start from offset 0 to ensure no messages are skipped
maxOffset = 0: empty queue, start from 0 (no messages to consume)
maxOffset = 1: single message at offset 0, start from 0 to consume it
maxOffset > 1: multiple messages, start from maxOffset (last position)
Fixes #9535
Brief Description
How Did You Test This Change?
Added 8 new test methods to the existing RebalancePushImplTest class to test various edge cases of the maxOffset method.