[ISSUE #9581] Optimize the resource bloat of pollingMap and topicCidMap in LMQ scenarios#9579
Merged
RongtongJin merged 2 commits intoapache:developfrom Sep 8, 2025
Merged
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## develop #9579 +/- ##
=============================================
- Coverage 48.13% 48.04% -0.10%
+ Complexity 12074 12044 -30
=============================================
Files 1313 1313
Lines 92791 92789 -2
Branches 11866 11862 -4
=============================================
- Hits 44667 44576 -91
- Misses 42628 42700 +72
- Partials 5496 5513 +17 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
RongtongJin
changed the title
tianliuliu
approved these changes
Aug 7, 2025
| private final ConcurrentLinkedHashMap<String, ConcurrentHashMap<String, Byte>> topicCidMap; | ||
| private final ConcurrentLinkedHashMap<String, ConcurrentSkipListSet<PopRequest>> pollingMap; | ||
| private final Cache<String, ConcurrentHashMap<String, Byte>> topicCidMap; | ||
| private final Cache<String, ConcurrentSkipListSet<PopRequest>> pollingMap; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which Issue(s) This PR Fixes
Fixes #9581
In the LMQ scenario, the system cannot determine whether a topic or subscription actually exists (LMQ assumes all of them exist by default). As a result, the cleanUnusedResource becomes ineffective, and after prolonged operation the sizes of topicCidMap and pollingMap grow close to their maximumSize, wasting memory and CPU.
Introduce a Caffeine cache so that entries automatically expire after they have been absent for a prolonged period.
Brief Description
Introduce a Caffeine cache so that entries automatically expire after they have been absent for a prolonged period.
How Did You Test This Change?