Skip to content

[ISSUE #9596] Optimize log in invokeSync when addr is null#9597

Merged
lizhimins merged 1 commit intoapache:developfrom
1782935682:fix/optimize_log
Aug 6, 2025
Merged

[ISSUE #9596] Optimize log in invokeSync when addr is null#9597
lizhimins merged 1 commit intoapache:developfrom
1782935682:fix/optimize_log

Conversation

@1782935682
Copy link
Copy Markdown
Contributor

Which Issue(s) This PR Fixes

Fixes #9596

Brief Description

How Did You Test This Change?

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Aug 4, 2025

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 48.04%. Comparing base (e4b731c) to head (4d4bcb0).
⚠️ Report is 9 commits behind head on develop.

Files with missing lines Patch % Lines
...e/rocketmq/remoting/netty/NettyRemotingClient.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #9597      +/-   ##
=============================================
- Coverage      48.10%   48.04%   -0.07%     
+ Complexity     12063    12049      -14     
=============================================
  Files           1313     1313              
  Lines          92771    92791      +20     
  Branches       11862    11866       +4     
=============================================
- Hits           44629    44582      -47     
- Misses         42636    42691      +55     
- Partials        5506     5518      +12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Contributor

@qianye1001 qianye1001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lizhimins lizhimins changed the title Optimize log in invokeSync when addr is null [ISSUE #9596] Optimize log in invokeSync when addr is null Aug 6, 2025
@lizhimins lizhimins merged commit 9609722 into apache:develop Aug 6, 2025
14 of 19 checks passed
hechen0 pushed a commit to hechen0/rocketmq that referenced this pull request Aug 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Enhancement] Optimize log in invokeSync when addr is null

4 participants