[ISSUE #9600] fix: remove wrong logic in the callback for sending messages in rpc#9608
Merged
tianliuliu merged 1 commit intoapache:developfrom Aug 12, 2025
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #9608 +/- ##
=============================================
- Coverage 48.14% 48.03% -0.12%
+ Complexity 12075 12045 -30
=============================================
Files 1313 1313
Lines 92791 92788 -3
Branches 11866 11867 +1
=============================================
- Hits 44675 44569 -106
- Misses 42620 42709 +89
- Partials 5496 5510 +14 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
tianliuliu
approved these changes
Aug 12, 2025
| @Override | ||
| public void onSuccess(SendResult sendResult) { | ||
| requestResponseFuture.setSendRequestOk(true); | ||
| requestResponseFuture.acquireCountDownLatch(); |
hechen0
pushed a commit
to hechen0/rocketmq
that referenced
this pull request
Aug 18, 2025
…pache#9608) Co-authored-by: hqbfzwang <hqbfzwang@tencent.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which Issue(s) This PR Fixes
Fixes #9600
the logic should be executed in ClientRemotingProcessor#processReplyMessage
Brief Description
How Did You Test This Change?