Skip to content

[ISSUE #9611] Should exec callback in the Pop based on rocksdb impl#9612

Merged
lollipopjin merged 1 commit intoapache:developfrom
lizhimins:zhimin/fix-pop-metrics
Aug 12, 2025
Merged

[ISSUE #9611] Should exec callback in the Pop based on rocksdb impl#9612
lollipopjin merged 1 commit intoapache:developfrom
lizhimins:zhimin/fix-pop-metrics

Conversation

@lizhimins
Copy link
Copy Markdown
Member

Which Issue(s) This PR Fixes

Fixes #9611

Brief Description

How Did You Test This Change?

Copy link
Copy Markdown
Contributor

@qianye1001 qianye1001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 47.94%. Comparing base (9e2445e) to head (d09edf0).

Files with missing lines Patch % Lines
...rocketmq/broker/processor/PopMessageProcessor.java 0.00% 6 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #9612      +/-   ##
=============================================
- Coverage      47.94%   47.94%   -0.01%     
- Complexity     12026    12028       +2     
=============================================
  Files           1313     1313              
  Lines          92838    92844       +6     
  Branches       11869    11870       +1     
=============================================
- Hits           44515    44512       -3     
- Misses         42795    42800       +5     
- Partials        5528     5532       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Contributor

@lollipopjin lollipopjin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lollipopjin lollipopjin merged commit c05dcdc into apache:develop Aug 12, 2025
10 of 13 checks passed
hechen0 pushed a commit to hechen0/rocketmq that referenced this pull request Aug 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] Should exec callback in the new Pop based on rocksdb impl

4 participants