Skip to content

[ISSUE #9687] Cleanup BrokerHeartbeatManager code #9688

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
RongtongJin merged 1 commit into from
Sep 24, 2025
Merged

[ISSUE #9687] Cleanup BrokerHeartbeatManager code #9688

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions controller/src/main/java/org/apache/rocketmq/controller/BrokerHeartbeatManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,9 +26,9 @@
import java.util.Map;

public interface BrokerHeartbeatManager {
public static final long DEFAULT_BROKER_CHANNEL_EXPIRED_TIME = 1000 * 10;
long DEFAULT_BROKER_CHANNEL_EXPIRED_TIME = 1000 * 10;

public static BrokerHeartbeatManager newBrokerHeartbeatManager(ControllerConfig controllerConfig) {
static BrokerHeartbeatManager newBrokerHeartbeatManager(ControllerConfig controllerConfig) {
if (controllerConfig.getControllerType().equals(ControllerConfig.JRAFT_CONTROLLER)) {
return new RaftBrokerHeartBeatManager(controllerConfig);
} else {
Expand All @@ -37,9 +37,7 @@ public static BrokerHeartbeatManager newBrokerHeartbeatManager(ControllerConfig
}

/**
* initialize the resources
*
* @return
* Initialize the resources
*/
void initialize();

Expand Down Expand Up @@ -72,6 +70,8 @@ void onBrokerHeartbeat(final String clusterName, final String brokerName, final

/**
* Get broker live information by clusterName and brokerAddr
*
* @return broker live information or null if not found
*/
BrokerLiveInfo getBrokerLiveInfo(String clusterName, String brokerName, Long brokerId);

Expand Down
Loading