Skip to content

[ISSUE #9693] Add writeWithoutMmap configuration to prevent JVM crash when device becomes read-only#9694

Merged
RongtongJin merged 2 commits intoapache:developfrom
guyinyou:dev_add_write_without_mmap
Sep 14, 2025
Merged

[ISSUE #9693] Add writeWithoutMmap configuration to prevent JVM crash when device becomes read-only#9694
RongtongJin merged 2 commits intoapache:developfrom
guyinyou:dev_add_write_without_mmap

Conversation

@guyinyou
Copy link
Copy Markdown
Contributor

Which Issue(s) This PR Fixes

Fixes #9693

Brief Description

How Did You Test This Change?

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Sep 12, 2025

Codecov Report

❌ Patch coverage is 81.25000% with 27 lines in your changes missing coverage. Please review.
✅ Project coverage is 48.16%. Comparing base (40622ce) to head (3b5555f).
⚠️ Report is 119 commits behind head on develop.

Files with missing lines Patch % Lines
...ache/rocketmq/store/logfile/DefaultMappedFile.java 80.39% 11 Missing and 9 partials ⚠️
...ache/rocketmq/store/AllocateMappedFileService.java 40.00% 2 Missing and 1 partial ⚠️
...ache/rocketmq/store/config/MessageStoreConfig.java 50.00% 2 Missing ⚠️
...n/java/org/apache/rocketmq/store/ConsumeQueue.java 80.00% 0 Missing and 1 partial ⚠️
...ava/org/apache/rocketmq/store/ConsumeQueueExt.java 90.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #9694      +/-   ##
=============================================
+ Coverage      48.14%   48.16%   +0.02%     
- Complexity     12081    12127      +46     
=============================================
  Files           1313     1313              
  Lines          92837    93079     +242     
  Branches       11864    11890      +26     
=============================================
+ Hits           44695    44833     +138     
- Misses         42642    42710      +68     
- Partials        5500     5536      +36     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@RongtongJin RongtongJin merged commit 4ae0294 into apache:develop Sep 14, 2025
20 of 26 checks passed
@RongtongJin RongtongJin added the ha label Sep 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Enhancement] Add writeWithoutMmap configuration to prevent JVM crash when device becomes read-only

3 participants