[ISSUE #9705] Improve persist() method reliability to prevent broker startup failure after power outages#9706
Merged
RongtongJin merged 13 commits intoapache:developfrom Sep 18, 2025
Merged
Conversation
added 6 commits
September 15, 2025 17:29
- Add atomic file backup mechanism in persist() methods - Delete corrupted config files during startup to avoid bak file pollution - Add directory sync to ensure file operations visibility Fixes: TimerMetrics#persist, TransactionMetrics#persist, ConfigManager#persist
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## develop #9706 +/- ##
=============================================
- Coverage 48.22% 48.12% -0.11%
+ Complexity 12167 12139 -28
=============================================
Files 1313 1313
Lines 93238 93233 -5
Branches 11950 11944 -6
=============================================
- Hits 44966 44866 -100
- Misses 42708 42793 +85
- Partials 5564 5574 +10 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
RongtongJin
approved these changes
Sep 18, 2025
lizhimins
added a commit
to lizhimins/rocketmq
that referenced
this pull request
Oct 13, 2025
This reverts commit 0e72809. Change-Id: Ibd3ad0f35020c5fa97b1435e938f95da908b8ad5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: TimerMetrics#persist, TransactionMetrics#persist, ConfigManager#persist
Which Issue(s) This PR Fixes
Fixes #9705
Brief Description
How Did You Test This Change?