[ISSUE #9726] Abstract StoreMetricsManager interface to support non-DefaultMessageStore implementations#9727
Merged
ltamber merged 1 commit intoapache:developfrom Sep 24, 2025
Merged
Conversation
…ltMessageStore - Create StoreMetricsManager interface to define unified metrics management methods - Add getStoreMetricsManager() method to MessageStore interface - Add flushBehindBytes() method to MessageStore interface to fix missing method calls - Refactor DefaultStoreMetricsManager to implement StoreMetricsManager interface - Update all MessageStore implementations to support the new interface - Modify TimerMessageStore to use getStoreMetricsManager() instead of direct type checking This refactoring resolves the issue where incTimerDequeueCount and incTimerEnqueueCount methods cannot be called when messageStore is not a DefaultMessageStore, improving code extensibility and decoupling.
RongtongJin
force-pushed
the
dev-0923
branch
from
427a3bf to
d56bd5e
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## develop #9727 +/- ##
=============================================
- Coverage 48.21% 48.16% -0.06%
+ Complexity 12166 12158 -8
=============================================
Files 1313 1313
Lines 93335 93339 +4
Branches 11962 11962
=============================================
- Hits 45005 44960 -45
- Misses 42762 42801 +39
- Partials 5568 5578 +10 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
fuyou001
approved these changes
Sep 24, 2025
ltamber
approved these changes
Sep 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which Issue(s) This PR Fixes
Fixes #9726
Brief Description
StoreMetricsManagerinterface to define unified metrics management methodsgetStoreMetricsManager()method toMessageStoreinterfaceflushBehindBytes()method toMessageStoreinterface (fixes missing method calls)DefaultStoreMetricsManagerto implementStoreMetricsManagerinterfaceTimerMessageStoreto usegetStoreMetricsManager()instead of direct type checkingHow Did You Test This Change?