Skip to content

[ISSUE #9750] Fix NPE when isAsyncSendEnable is false#9751

Merged
lizhimins merged 1 commit intoapache:developfrom
RongtongJin:develop-1013
Oct 14, 2025
Merged

[ISSUE #9750] Fix NPE when isAsyncSendEnable is false#9751
lizhimins merged 1 commit intoapache:developfrom
RongtongJin:develop-1013

Conversation

@RongtongJin
Copy link
Copy Markdown
Contributor

Which Issue(s) This PR Fixes

Fixes #9750
Fixed NPE issue in transaction metrics recording logic when isAsyncSendEnable is false.

Brief Description

  • Solution: Added sendTransactionPrepareMessage check in the condition to ensure transaction metrics are only recorded when processing transaction prepare messages
  • Consistency: Aligns with the logic in asynchronous send mode (line 342 already has the same condition check)

How Did You Test This Change?

Change-Id: I62fe32fa1a9788d3d1501d0badf5d02d48500a8f
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Oct 13, 2025

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 48.23%. Comparing base (40ca80e) to head (57e9bc4).
⚠️ Report is 158 commits behind head on develop.

Files with missing lines Patch % Lines
...ocketmq/broker/processor/SendMessageProcessor.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #9751      +/-   ##
=============================================
- Coverage      48.32%   48.23%   -0.10%     
+ Complexity     12193    12169      -24     
=============================================
  Files           1313     1313              
  Lines          93340    93340              
  Branches       11962    11962              
=============================================
- Hits           45111    45021      -90     
- Misses         42660    42734      +74     
- Partials        5569     5585      +16     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@lizhimins lizhimins merged commit 4a64a5a into apache:develop Oct 14, 2025
11 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Enhancement] Fix NPE when isAsyncSendEnable is false in transaction metrics recording

3 participants