Fix resource leak in IndexStoreFile shutdown#9840
Merged
ShannonDing merged 4 commits intoapache:developfrom Nov 14, 2025
Merged
Fix resource leak in IndexStoreFile shutdown#9840ShannonDing merged 4 commits intoapache:developfrom
ShannonDing merged 4 commits intoapache:developfrom
Conversation
added 3 commits
November 11, 2025 17:35
Add cleanResources() calls after shutdown() for both mappedFile and compactMappedFile to ensure proper cleanup of memory-mapped buffers and file channels. Change-Id: I2716b4e3b0cd281e89a9d5a00a389dc6048de3e7 Co-developed-by: Cursor <noreply@cursor.com>
…fter shutdown Change-Id: Icc0063544ef91de8b2bd96a80f3829a6922cb0e6
…fter shutdown. Change-Id: I53a7d2800775d80c1db8feb159c5c258b3517f09
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## develop #9840 +/- ##
=============================================
- Coverage 48.38% 48.28% -0.11%
+ Complexity 12276 12248 -28
=============================================
Files 1314 1314
Lines 93858 93864 +6
Branches 12043 12043
=============================================
- Hits 45415 45324 -91
- Misses 42836 42915 +79
- Partials 5607 5625 +18 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
fuyou001
previously approved these changes
Nov 12, 2025
Change-Id: I21cc78101a31e80bcf9a98165c267f1568444f1b
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which Issue(s) This PR Fixes
Fixes #issue_id
Brief Description
Add cleanResources() calls after shutdown() for both mappedFile and compactMappedFile to ensure proper cleanup of memory-mapped buffers and file channels.
How Did You Test This Change?