Skip to content

[ISSUE #9875] Optimize the RocksDB config shutdown logic when useSingleRocksDBForAllConfigs is set to true to prevent JVM crashes.#9874

Merged
ltamber merged 2 commits intoapache:developfrom
RongtongJin:develop-1125
Nov 26, 2025
Merged

[ISSUE #9875] Optimize the RocksDB config shutdown logic when useSingleRocksDBForAllConfigs is set to true to prevent JVM crashes.#9874
ltamber merged 2 commits intoapache:developfrom
RongtongJin:develop-1125

Conversation

@RongtongJin
Copy link
Copy Markdown
Contributor

@RongtongJin RongtongJin commented Nov 25, 2025

Change-Id: I309e8d13b6adc46d68146c05ffd7e026e2852ad8

Which Issue(s) This PR Fixes

Fixes #9875

Brief Description

Optimize the RocksDB config shutdown logic when useSingleRocksDBForAllConfigs is set to true to prevent JVM crashes

How Did You Test This Change?

RongtongJin added 2 commits November 25, 2025 15:43
…lConfigs is set to true to prevent JVM crashes.

Change-Id: I309e8d13b6adc46d68146c05ffd7e026e2852ad8
Change-Id: Ie577e32f65a3902dd60d654f80a8e7eda5790fbf
@RongtongJin RongtongJin changed the title Optimize the RocksDB config shutdown logic when useSingleRocksDBForAllConfigs is set to true to prevent JVM crashes. [ISSUE #9875] Optimize the RocksDB config shutdown logic when useSingleRocksDBForAllConfigs is set to true to prevent JVM crashes. Nov 25, 2025
Copy link
Copy Markdown
Contributor

@guyinyou guyinyou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 48.30%. Comparing base (f33f626) to head (7cfbb00).

Files with missing lines Patch % Lines
...ocketmq/broker/config/v1/RocksDBConfigManager.java 0.00% 0 Missing and 2 partials ⚠️
...broker/config/v1/RocksDBConsumerOffsetManager.java 0.00% 0 Missing and 1 partial ⚠️
...rocketmq/common/config/AbstractRocksDBStorage.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #9874      +/-   ##
=============================================
- Coverage      48.38%   48.30%   -0.08%     
+ Complexity     12281    12258      -23     
=============================================
  Files           1314     1314              
  Lines          93894    93893       -1     
  Branches       12046    12046              
=============================================
- Hits           45430    45356      -74     
- Misses         42857    42914      +57     
- Partials        5607     5623      +16     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@RongtongJin RongtongJin added the ha label Nov 25, 2025
@ltamber ltamber merged commit e87f9cb into apache:develop Nov 26, 2025
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] JVM crash when executing shutdown if useSingleRocksDBForAllConfigs is true

5 participants