Skip to content

[ISSUE #9898] Remove AbstractBrokerRunnable and replace with Runnable#9893

Merged
RongtongJin merged 1 commit intoapache:developfrom
RongtongJin:dev-1201-1
Dec 5, 2025
Merged

[ISSUE #9898] Remove AbstractBrokerRunnable and replace with Runnable#9893
RongtongJin merged 1 commit intoapache:developfrom
RongtongJin:dev-1201-1

Conversation

@RongtongJin
Copy link
Copy Markdown
Contributor

@RongtongJin RongtongJin commented Dec 3, 2025

Change-Id: I94104151c452d09cbe195a3e1126a473b662a337

Which Issue(s) This PR Fixes

Fixes #9898

Brief Description

Keeping the brokerContainer logs unseparated and maintaining their original state is actually clearer.
Remove AbstractBrokerRunnable and replace with Runnable

How Did You Test This Change?

Change-Id: I94104151c452d09cbe195a3e1126a473b662a337
@RongtongJin RongtongJin marked this pull request as draft December 3, 2025 07:18
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Dec 3, 2025

Codecov Report

❌ Patch coverage is 48.00000% with 13 lines in your changes missing coverage. Please review.
✅ Project coverage is 48.29%. Comparing base (63d20eb) to head (89b3400).
⚠️ Report is 108 commits behind head on develop.

Files with missing lines Patch % Lines
...org/apache/rocketmq/broker/out/BrokerOuterAPI.java 20.00% 8 Missing ⚠️
...a/org/apache/rocketmq/broker/BrokerController.java 33.33% 2 Missing ⚠️
...org/apache/rocketmq/container/BrokerContainer.java 33.33% 2 Missing ⚠️
...ache/rocketmq/container/InnerBrokerController.java 50.00% 1 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #9893      +/-   ##
=============================================
- Coverage      48.39%   48.29%   -0.10%     
+ Complexity     12283    12259      -24     
=============================================
  Files           1314     1314              
  Lines          93903    93910       +7     
  Branches       12046    12046              
=============================================
- Hits           45443    45355      -88     
- Misses         42852    42935      +83     
- Partials        5608     5620      +12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@RongtongJin RongtongJin changed the title Remove AbstractBrokerRunnable and replace with Runnable [ISSUE #9898] Remove AbstractBrokerRunnable and replace with Runnable Dec 5, 2025
@RongtongJin RongtongJin marked this pull request as ready for review December 5, 2025 03:39
Copy link
Copy Markdown
Contributor

@guyinyou guyinyou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@RongtongJin RongtongJin merged commit 89e021e into apache:develop Dec 5, 2025
18 of 23 checks passed
@RongtongJin RongtongJin added the ha label Mar 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Enhancement] Remove AbstractBrokerRunnable and replace with Runnable

4 participants