Skip to content

[ISSUE #9978] Remove static from loadJsonConfig and unify exception s… #9979

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lizhimins merged 1 commit into from
Jan 14, 2026
Merged

[ISSUE #9978] Remove static from loadJsonConfig and unify exception s… #9979

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions proxy/src/main/java/org/apache/rocketmq/proxy/config/Configuration.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ public void init() throws Exception {
authConfig.setClusterName(proxyConfig.getRocketMQClusterName());
}

public static String loadJsonConfig() throws Exception {
private String loadJsonConfig() throws Exception {
String configFileName = ProxyConfig.DEFAULT_CONFIG_FILE_NAME;
String filePath = System.getProperty(CONFIG_PATH_PROPERTY);
if (StringUtils.isBlank(filePath)) {
Expand All @@ -67,13 +67,15 @@ public static String loadJsonConfig() throws Exception {
File file = new File(filePath);
log.info("The current configuration file path is {}", filePath);
if (!file.exists()) {
log.warn("the config file {} not exist", filePath);
throw new RuntimeException(String.format("the config file %s not exist", filePath));
String msg = String.format("the config file %s not exist", filePath);
log.warn(msg);
throw new RuntimeException(msg);
}
long fileLength = file.length();
if (fileLength <= 0) {
log.warn("the config file {} length is zero", filePath);
throw new RuntimeException(String.format("the config file %s length is zero", filePath));
String msg = String.format("the config file %s length is zero", filePath);
log.warn(msg);
throw new RuntimeException(msg);
}

return new String(Files.readAllBytes(file.toPath()), StandardCharsets.UTF_8);
Expand Down
Loading