[ISSUE #9980] Skip invalid POP records when consumer group does not exist (#9980)#9982
Merged
lizhimins merged 2 commits intoapache:developfrom Jan 20, 2026
Merged
Conversation
Contributor
Author
|
Local build and full reactor completed successfully on JDK 17. |
Member
|
must remove flattened-pom.xml from your pr |
lizhimins
changed the title
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #9982 +/- ##
=============================================
- Coverage 48.84% 48.74% -0.11%
+ Complexity 12773 12741 -32
=============================================
Files 1324 1324
Lines 96405 96412 +7
Branches 12434 12436 +2
=============================================
- Hits 47093 46993 -100
- Misses 43571 43662 +91
- Partials 5741 5757 +16 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Aman Gautam <amangautam2128@gmail.com>
Contributor
Author
|
Thanks for pointing this out all generated .flattened-pom.xml files have been removed from the PR. |
lizhimins
approved these changes
Jan 14, 2026
lizhimins
approved these changes
Jan 20, 2026
dingshuangxi888
pushed a commit
to dingshuangxi888/rocketmq
that referenced
this pull request
Feb 10, 2026
… not exist (apache#9982) Signed-off-by: Aman Gautam <amangautam2128@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Skip invalid POP records when the consumer group does not exist, preventing
unnecessary checkpoint and retry message generation.
Why is it needed?
Currently, POP checkpoints may still be written even if the consumer group
is absent, leading to invalid retries and wasted resources.
How was this tested?
Verified locally with broker module build and full reactor build.
All quality checks (SpotBugs, Checkstyle) pass.
Related Issue
Fixes #9980