Skip to content

feat(sedona-spatial-join): Fix for the customized join provider that may not take effective#766

Merged
paleolimbot merged 1 commit intoapache:mainfrom
pwrliang:fix/join_provider
Apr 16, 2026
Merged

feat(sedona-spatial-join): Fix for the customized join provider that may not take effective#766
paleolimbot merged 1 commit intoapache:mainfrom
pwrliang:fix/join_provider

Conversation

@pwrliang
Copy link
Copy Markdown
Contributor

We have provided a method (#722) with_spatial_join_provider to overwrite the DefaultSpatialJoinProvider with a customized one by calling with_spatial_join_provider ofSpatialJoinExec.

    pub fn with_spatial_join_provider(
        mut self,
        join_provider: Arc<dyn SpatialJoinProvider>,
    ) -> Self {
        self.join_provider = join_provider;
        self
    }

However, there are many methods in SpatialJoinExec, such as swap_inputs, that return a modified SpatialJoinExec by calling try_new_internal, which binds join_provider to DefaultSpatialJoinProvider again. We need to call with_spatial_join_provider after the returning of a SpatialJoinExec object to overwrite it.

@github-actions github-actions Bot requested a review from zhangfengcdt April 16, 2026 07:18
@pwrliang
Copy link
Copy Markdown
Contributor Author

Do you prefer this modification or add an extra parameter join_provider to the constructors of SpatialJoinExec? @paleolimbot

@pwrliang pwrliang changed the title feat(sedona-spatial-join): Fix for the customized join provider may not take effective feat(sedona-spatial-join): Fix for the customized join provider that may not take effective Apr 16, 2026
Copy link
Copy Markdown
Member

@paleolimbot paleolimbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@paleolimbot paleolimbot merged commit 742e851 into apache:main Apr 16, 2026
18 checks passed
@pwrliang pwrliang deleted the fix/join_provider branch April 20, 2026 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants