fix: Copilot review comments

lib/helpers.ts

@@ -28,16 +28,6 @@ export function getXcrunBinary(): string {
   return process.env.XCRUN_BINARY || 'xcrun';
 }
 
-/**
- * Generate a UUID v4
- *
- * @returns Promise resolving to UUID string
- */
-export async function uuidV4(): Promise<string> {
-  const uuidLib = await import('uuid');
-  return uuidLib.v4();
-}
-
 /**
  * Convert plist-style output to JSON using plutil
  *

lib/subcommands/io.ts

@@ -1,8 +1,8 @@
 import {rimraf} from 'rimraf';
+import {randomUUID} from 'node:crypto';
 import path from 'node:path';
 import os from 'node:os';
 import fs from 'node:fs/promises';
-import {uuidV4} from '../helpers';
 import type {Simctl} from '../simctl';
 
 /**
@@ -17,7 +17,7 @@ import type {Simctl} from '../simctl';
  */
 export async function getScreenshot(this: Simctl): Promise<string> {
   const udid = this.requireUdid('io screenshot');
-  const pathToScreenshotPng = path.resolve(os.tmpdir(), `${await uuidV4()}.png`);
+  const pathToScreenshotPng = path.resolve(os.tmpdir(), `${randomUUID()}.png`);
   try {
     await this.exec('io', {
       args: [udid, 'screenshot', pathToScreenshotPng],

lib/subcommands/push.ts

@@ -1,5 +1,5 @@
 import {rimraf} from 'rimraf';
-import {uuidV4} from '../helpers';
+import {randomUUID} from 'node:crypto';
 import path from 'node:path';
 import os from 'node:os';
 import fs from 'node:fs/promises';
@@ -26,7 +26,7 @@ import type {Simctl} from '../simctl';
  * @throws {Error} If the `udid` instance property is unset
  */
 export async function pushNotification(this: Simctl, payload: Record<string, any>): Promise<void> {
-  const dstPath = path.resolve(os.tmpdir(), `${await uuidV4()}.json`);
+  const dstPath = path.resolve(os.tmpdir(), `${randomUUID()}.json`);
   try {
     await fs.writeFile(dstPath, JSON.stringify(payload), 'utf8');
     await this.exec('push', {

test/e2e/simctl-e2e-specs.ts

@@ -2,7 +2,7 @@ import {Simctl} from '../../lib/simctl';
 import xcode from 'appium-xcode';
 import {retryInterval} from 'asyncbox';
 import {rimraf} from 'rimraf';
-import {uuidV4} from '../../lib/helpers';
+import {randomUUID} from 'node:crypto';
 import path from 'node:path';
 import os from 'node:os';
 import fs from 'node:fs/promises';
@@ -109,7 +109,7 @@ describe('simctl', function () {
     it('should delete devices', async function () {
       await simctl.deleteDevice();
       const sdkDevices = await simctl.getDevices(sdk);
-      expect(sdkDevices.map((item) => item.name)).to.not.include(simctl.udid);
+      expect(sdkDevices.map((item) => item.udid)).to.not.include(simctl.udid);
 
       // so we do not delete again
       simctl.udid = null;
@@ -219,7 +219,7 @@ describe('simctl', function () {
         if (major < 8 || (major === 8 && minor < 1)) {
           return this.skip();
         }
-        picturePath = path.join(os.tmpdir(), `${await uuidV4()}.png`);
+        picturePath = path.join(os.tmpdir(), `${randomUUID()}.png`);
         await fs.writeFile(
           picturePath,
           Buffer.from(BASE64_PNG, 'base64').toString('binary'),