Minor refactor changes & documentation update

Author: arimger

Assets/Editor Toolbox/Editor/Drawers/Toolbox/Decorator/EditorButtonAttributeDrawer.cs

@@ -9,11 +9,6 @@ namespace Toolbox.Editor.Drawers
 {
     public class EditorButtonAttributeDrawer : ToolboxDecoratorDrawer<EditorButtonAttribute>
     {
-        private bool IsCoroutine(MethodInfo method)
-        {
-            return method.ReturnType == typeof(IEnumerator);
-        }
-
         private MethodInfo GetMethod(EditorButtonAttribute attribute, Object[] targetObjects, string methodName)
         {
             var methodInfo = ReflectionUtility.GetObjectMethod(methodName, targetObjects);
@@ -33,6 +28,11 @@ private MethodInfo GetMethod(EditorButtonAttribute attribute, Object[] targetObj
             return methodInfo;
         }
 
+        private static bool IsCoroutine(MethodInfo methodInfo)
+        {
+            return methodInfo.ReturnType == typeof(IEnumerator);
+        }
+
         private bool IsClickable(ButtonActivityType activityType)
         {
             switch (activityType)
@@ -58,7 +58,7 @@ private bool IsClickable(EditorButtonAttribute attribute, Object[] targetObjects
             }
 
             var validateMethodName = attribute.ValidateMethodName;
-            if (string.IsNullOrEmpty(validateMethodName))
+            if (validateMethodName == null)
             {
                 return true;
             }
@@ -84,8 +84,7 @@ private bool IsClickable(EditorButtonAttribute attribute, Object[] targetObjects
                     continue;
                 }
 
-                var result = (bool)validateMethodInfo.Invoke(target, null);
-                if (!result)
+                if (!(bool)validateMethodInfo.Invoke(target, null))
                 {
                     return false;
                 }
@@ -96,19 +95,9 @@ private bool IsClickable(EditorButtonAttribute attribute, Object[] targetObjects
 
         private void CallMethods(EditorButtonAttribute attribute, Object[] targetObjects)
         {
-            var methodInfo = ReflectionUtility.GetObjectMethod(attribute.MethodName, targetObjects);
-            //validate method name (check if method exists)
+            var methodInfo = GetMethod(attribute, targetObjects, attribute.MethodName);
             if (methodInfo == null)
             {
-                ToolboxEditorLog.AttributeUsageWarning(attribute, string.Format("{0} method not found.", attribute.MethodName));
-                return;
-            }
-
-            //validate parameters count and log warning
-            var parameters = methodInfo.GetParameters();
-            if (parameters.Length > 0)
-            {
-                ToolboxEditorLog.AttributeUsageWarning(attribute, string.Format("{0} method has to be parameterless.", attribute.MethodName));
                 return;
             }
 

Assets/Editor Toolbox/README.md

@@ -313,13 +313,18 @@ public int var1;
 public int var1;
 ```
 ```csharp
-[EditorButton(nameof(MyMethod), "<b>My</b> Custom Label", activityType: ButtonActivityType.OnPlayMode)]
+[EditorButton(nameof(MyMethod), "<b>My</b> Custom Label", activityType: ButtonActivityType.OnPlayMode, ValidateMethodName = nameof(ValidationMethod))]
 public int var1;
 
 private void MyMethod()
 {
 	Debug.Log("MyMethod is invoked");
 }
+
+private bool ValidationMethod()
+{
+	return var1 == 0;
+}
 ```
 ```csharp
 [Highlight(0, 1, 0)]

Assets/Editor Toolbox/Runtime/Attributes/Toolbox/DecoratorAttributes/EditorButtonAttribute.cs

@@ -22,6 +22,7 @@ public EditorButtonAttribute(string methodName, string extraLabel = null, Button
         public string MethodName { get; private set; }
         /// <summary>
         /// If not <see langword="null"/> will be used to retrive validation method.
+        /// Validation method will be used to disable/enable the button in the Inspector Window.
         /// </summary>
         public string ValidateMethodName { get; set; }
         public string ExtraLabel { get; private set; }

README.md

@@ -313,13 +313,18 @@ public int var1;
 public int var1;
 ```
 ```csharp
-[EditorButton(nameof(MyMethod), "<b>My</b> Custom Label", activityType: ButtonActivityType.OnPlayMode)]
+[EditorButton(nameof(MyMethod), "<b>My</b> Custom Label", activityType: ButtonActivityType.OnPlayMode, ValidateMethodName = nameof(ValidationMethod))]
 public int var1;
 
 private void MyMethod()
 {
 	Debug.Log("MyMethod is invoked");
 }
+
+private bool ValidationMethod()
+{
+	return var1 == 0;
+}
 ```
 ```csharp
 [Highlight(0, 1, 0)]