Pin grpc-js temporarily to work around issue#207
Merged
tstirrat15 merged 1 commit intomainfrom Mar 25, 2025
Merged
Conversation
vroldanbet
approved these changes
Mar 25, 2025
vroldanbet
requested changes
Mar 25, 2025
Contributor
vroldanbet
left a comment
vroldanbet
left a comment
There was a problem hiding this comment.
change looks good, but making sure we don't merge until we sort out CI
tstirrat15
force-pushed
the
pin-grpc-js-for-bugfix
branch
from
882f093 to
e027806
Compare
vroldanbet
approved these changes
Mar 25, 2025
Contributor
Author
|
note on this: the previous test failures on this PR indicated that we did encounter the bug and it's captured in our tests. we should be able to write a proper fix to #206 based on that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #206
Description
Users reported breakage of the
authzed-nodelib related to ourKnownInsecureChannelCredentialsimplementation (see issue for details). This appears to be related to the v1.13.0 or v1.13.1 release of grpc-js, though it's unclear what part of those releases would be related.Changes
~instead of^)Testing
Review. See that tests pass.