Pin grpc-js to version that works with the code we're using #216
Closed
tstirrat15 wants to merge 1 commit intomainfrom
Closed
Pin grpc-js to version that works with the code we're using #216tstirrat15 wants to merge 1 commit intomainfrom
tstirrat15 wants to merge 1 commit intomainfrom
Conversation
Contributor
Author
|
Nvm, didn't realize that #212 hasn't gone in yet. Gonna close this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In #212, we changed the code that we're using to implement the insecure channel credentials; we didn't also bump this version. If a user currently has a matching 1.12.x version, they won't get the upgrade, and their install of
authzed-nodewon't work. This fixes that problem.Note that we wouldn't have caught that in tests because this would only materialize for someone using a lockfile, and this package doesn't have a lockfile.
Changes
Testing
Review; see that tests go green.