Creating metadata object to not expose raw protobuf#230
Merged
tstirrat15 merged 6 commits intoauthzed:mainfrom Jun 16, 2025
Merged
Creating metadata object to not expose raw protobuf#230tstirrat15 merged 6 commits intoauthzed:mainfrom
tstirrat15 merged 6 commits intoauthzed:mainfrom
Conversation
tstirrat15
reviewed
Jun 5, 2025
Contributor
tstirrat15
left a comment
There was a problem hiding this comment.
See comments - I'm not sure the restrictions are necessary
tstirrat15
approved these changes
Jun 11, 2025
Contributor
tstirrat15
left a comment
There was a problem hiding this comment.
This looks good. Thank you!
Contributor
|
The failures can be fixed with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
optionalTransactionMetadatais using theStructobject from the google protobuf package. Instead of exposing that to the client, it would be better to encapsulate that within theauthzedlibrary. This PR creates a utility to build the struct object.So this enables the client to add relationships this way: