Improve code to phpstan level 5

Author: DigitalTimK

phpstan.neon

@@ -1,5 +1,5 @@
 parameters:
-    level: 4
+    level: 5
     paths:
         - src/
         - tests/

tests/Parameters/CreateMeetingParametersTest.php

@@ -126,7 +126,7 @@ public function testCreateBreakoutMeeting()
 
         $this->assertStringContainsString('isBreakout=' . urlencode($createBreakoutMeetingParams->isBreakout() ? 'true' : 'false'), $params);
         $this->assertStringContainsString('parentMeetingID=' . urlencode($createBreakoutMeetingParams->getParentMeetingId()), $params);
-        $this->assertStringContainsString('sequence=' . urlencode($createBreakoutMeetingParams->getSequence()), $params);
+        $this->assertStringContainsString('sequence=' . urlencode((string) $createBreakoutMeetingParams->getSequence()), $params);
         $this->assertStringContainsString('freeJoin=' . urlencode($createBreakoutMeetingParams->isFreeJoin() ? 'true' : 'false'), $params);
     }
 

tests/Parameters/GetMeetingInfoParametersTest.php

@@ -36,14 +36,16 @@ public function testGetMeetingInfoParameters()
         $this->assertEquals($meetingId, $getMeetingInfoParams->getMeetingId());
 
         // Test setters that are ignored by the constructor
-        $newId = $this->faker->uuid;
+        $newId  = $this->faker->uuid;
+        $limit  = $this->faker->numberBetween(1, 99);
+        $offset = $this->faker->numberBetween(1, 99);
 
         $getMeetingInfoParams->setMeetingId($newId);
-        $getMeetingInfoParams->setMeetingId($limit = $this->faker->numberBetween(1, 99));
-        $getMeetingInfoParams->setMeetingId($offset = $this->faker->numberBetween(1, 99));
+        $getMeetingInfoParams->setLimit($limit);
+        $getMeetingInfoParams->setOffset($offset);
 
-        $this->assertNotEquals($newId, $getMeetingInfoParams->getMeetingId());
-        $this->assertNull($getMeetingInfoParams->getLimit());
-        $this->assertNull($getMeetingInfoParams->getOffset());
+        $this->assertEquals($newId, $getMeetingInfoParams->getMeetingId());
+        $this->assertEquals($limit, $getMeetingInfoParams->getLimit());
+        $this->assertEquals($offset, $getMeetingInfoParams->getOffset());
     }
 }

tests/Parameters/PublishRecordingsParametersTest.php

@@ -31,17 +31,20 @@ class PublishRecordingsParametersTest extends TestCase
 {
     public function testPublishRecordingsParameters()
     {
-        $recordingId      = $this->faker->uuid;
-        $publish          = $this->faker->boolean(50);
+        $recordingId    = $this->faker->uuid;
+        $publish        = $this->faker->boolean(50);
+        $newRecordingId = $this->faker->uuid;
+        $newPublish     = !$publish;
+
         $publishRecording = new PublishRecordingsParameters($recordingId, $publish);
 
         $this->assertEquals($recordingId, $publishRecording->getRecordingId());
         $this->assertEquals($publish, $publishRecording->isPublish());
 
         // Test setters that are ignored by the constructor
-        $publishRecording->setRecordingId($newRecordingId = !$this->faker->uuid);
-        $publishRecording->setPublish($publish = !$publish);
+        $publishRecording->setRecordingId($newRecordingId);
+        $publishRecording->setPublish($newPublish);
         $this->assertEquals($newRecordingId, $publishRecording->getRecordingId());
-        $this->assertEquals($publish, $publishRecording->isPublish());
+        $this->assertEquals($newPublish, $publishRecording->isPublish());
     }
 }