Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
@kris-ellery is attempting to deploy a commit to the Chakra UI Team on Vercel. A member of the Team first needs to authorize it. |
🦋 Changeset detectedLatest commit: 7815a33 The changes in this PR will be included in the next version bump. This PR includes changesets to release 24 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3509
📝 Description
Panda's static extractor now recognizes compiled JSX factory calls (
jsx,_jsx,jsxs,_jsxs,createElement) and extracts inline style objects from them.⛳️ Current behavior (updates)
When bundlers compile JSX,
<Box css={{ color: "red.900" }} />becomesjsx(Box, { css: { color: "red.900" } }). The extractor only handled JSX element syntax, so inline style objects in compiled output were silently dropped. This affects any library that ships compiled dist files and uses inline object literals with thecssprop.The two other patterns already worked:
css={styles}(variable viacss.raw()) — extracted at the definition sitecss={{ ...styles }}(spread) — same reason🚀 New behavior
A new detection block inside the existing
componentshandler recognizes compiled JSX call expressions and extracts the component name from the first argument and style props from the second argument. It produceskind: 'component'results, so the existing parser handles them with zero changes.Non-style props (
children,onClick,key, etc.) are filtered during extraction viamatchPropso they are never evaluated.💣 Is this a breaking change (Yes/No):
No
📝 Additional Information
atomic-rulesnapshot tests pass with no diffscssprop inline object literals not extracted from compiled (dist) files #3509