v3(services): response body for creating route binding (cloudfoundry#1800)

* v3(services): response body for creating route binding

[#174189258](https://www.pivotaltracker.com/story/show/174189258)

* fix docs link error

[#174189258](https://www.pivotaltracker.com/story/show/174189258)

Author: blgm

app/controllers/v3/service_route_bindings_controller.rb

@@ -1,5 +1,6 @@
 require 'messages/service_route_binding_create_message'
 require 'actions/service_route_binding_create'
+require 'presenters/v3/service_route_binding_presenter'
 
 class ServiceRouteBindingsController < ApplicationController
   def create
@@ -17,7 +18,7 @@ def create
       head :not_implemented
     when UserProvidedServiceInstance
       binding = action.create(service_instance, route)
-      render status: :created, json: { guid: binding.guid }.to_json
+      render status: :created, json: Presenters::V3::ServiceRouteBindingPresenter.new(binding)
     end
   rescue V3::ServiceRouteBindingCreate::UnprocessableCreate => e
     unprocessable!(e.message)

app/presenters/v3/service_route_binding_presenter.rb

@@ -0,0 +1,44 @@
+require_relative 'base_presenter'
+
+module VCAP
+  module CloudController
+    module Presenters
+      module V3
+        class ServiceRouteBindingPresenter < BasePresenter
+          def to_hash
+            {
+              guid: @resource.guid,
+              created_at: @resource.created_at,
+              updated_at: @resource.updated_at,
+              relationships: relationships,
+              links: links
+            }
+          end
+
+          private
+
+          def links
+            {
+              self: {
+                href: url_builder.build_url(path: "/v3/service_route_bindings/#{@resource.guid}")
+              },
+              service_instance: {
+                href: url_builder.build_url(path: "/v3/service_instances/#{@resource.service_instance.guid}")
+              },
+              route: {
+                href: url_builder.build_url(path: "/v3/routes/#{@resource.route.guid}")
+              }
+            }
+          end
+
+          def relationships
+            {
+              service_instance: { data: { guid: @resource.service_instance.guid } },
+              route: { data: { guid: @resource.route.guid } }
+            }
+          end
+        end
+      end
+    end
+  end
+end

docs/v3/source/includes/api_resources/_service_route_bindings.erb

@@ -0,0 +1,30 @@
+<% content_for :single_service_route_binding do %>
+{
+  "guid": "dde5ad2a-d8f4-44dc-a56f-0452d744f1c3",
+  "created_at": "2015-11-13T17:02:56Z",
+  "updated_at": "2016-06-08T16:41:26Z",
+  "relationships": {
+    "service_instance": {
+      "data": {
+        "guid": "74f7c078-0934-470f-9883-4fddss5b8f13"
+      }
+    },
+    "route": {
+      "data": {
+        "guid": "8bfe4c1b-9e18-45b1-83be-124163f31f9e"
+      }
+    }
+  },
+  "links": {
+    "self": {
+      "href": "https://api.example.org/v3/service_bindings/dde5ad2a-d8f4-44dc-a56f-0452d744f1c3"
+    },
+    "service_instance": {
+      "href": "https://api.example.org/v3/service_instances/8bfe4c1b-9e18-45b1-83be-124163f31f9e"
+    },
+    "route": {
+      "href": "https://api.example.org/v3/apps/74f7c078-0934-470f-9883-4fddss5b8f13"
+    }
+  }
+}
+<% end %>

docs/v3/source/includes/experimental_resources/service_route_bindings/_create.md.erb

@@ -0,0 +1,59 @@
+### Create a service route binding
+
+```
+Example Request
+```
+
+```shell
+curl "https://api.example.org/v3/service_route_bindings" \
+  -X POST \
+  -H "Authorization: bearer [token]" \
+  -H "Content-type: application/json" \
+  -d '{
+    "relationships": {
+      "route": {
+        "data": {
+          "guid": "7304bc3c-7010-11ea-8840-48bf6bec2d78"
+        }
+      },
+      "service_instance": {
+        "data": {
+          "guid": "e0e4417c-74ee-11ea-a604-48bf6bec2d78"
+        }
+      }
+    }
+  }'
+```
+
+```
+Example Response
+```
+
+```http
+HTTP/1.1 201 Created
+Content-Type: application/json
+
+<%= yield_content :single_service_route_binding %>
+```
+
+This endpoint creates a new route service binding. The service instance and the route
+must be in the same space.
+
+To bind to a route to a user-provided service instance, the service instance must
+have the `route_service_url` property set.
+
+#### Definition
+`POST /v3/service_route_bindings`
+
+#### Required parameters
+
+Name | Type | Description
+---- | ---- | -----------
+**relationships.route** | [_to-one relationship_](#to-one-relationships) | The route to bind
+**relationships.service_instance** | [_to-one relationship_](#to-one-relationships) | The service instance to bind
+
+#### Permitted roles
+ |
+--- | ---
+Admin |
+Space Developer |

docs/v3/source/includes/experimental_resources/service_route_bindings/_header.md

@@ -0,0 +1,3 @@
+## Service Route Binding (experimental)
+
+An instantiation of a service route binding.

docs/v3/source/includes/experimental_resources/service_route_bindings/_object.md.erb

@@ -0,0 +1,17 @@
+### The service route binding object
+
+```
+Example Service Route Binding object
+```
+```json
+<%= yield_content :single_service_route_binding %>
+```
+
+Name | Type | Description
+---- | ---- | -----------
+**guid** | _uuid_ | Unique identifier for the service credential binding
+**created_at** | _[timestamp](#timestamps)_ | The time with zone when the object was created
+**updated_at** | _[timestamp](#timestamps)_ | The time with zone when the object was last updated
+**relationships.service_instance** | [_to-one relationship_](#to-one-relationships) | The service instance that the route is bound to
+**relationships.route** | [_to-one relationship_](#to-one-relationships) | The route that the service instance is bound to
+**links** | [_links object_](#links) | Links to related resources

docs/v3/source/index.md

@@ -32,6 +32,7 @@ includes:
   - api_resources/service_plans
   - api_resources/service_plan_visibility
   - api_resources/service_credential_bindings
+  - api_resources/service_route_bindings
   - api_resources/service_instances
   - api_resources/service_usage_events
   - api_resources/sidecars
@@ -360,6 +361,9 @@ includes:
   - experimental_resources/service_credential_bindings/get
   - experimental_resources/service_credential_bindings/list
   - experimental_resources/service_credential_bindings/details
+  - experimental_resources/service_route_bindings/header
+  - experimental_resources/service_route_bindings/object
+  - experimental_resources/service_route_bindings/create
   - experimental_resources/service_instances/header
   - experimental_resources/service_instances/create
   - experimental_resources/service_instances/get

spec/request/service_route_bindings_spec.rb

@@ -164,12 +164,13 @@
         api_call.call(space_dev_headers)
         expect(last_response).to have_status_code(201)
 
-        binding = VCAP::CloudController::RouteBinding.first
-        expect(parsed_response['guid']).to eq(binding.guid)
-
-        expect(binding.service_instance).to eq(service_instance)
-        expect(binding.route).to eq(route)
-        expect(binding.route_service_url).to eq(route_service_url)
+        expect(parsed_response).to match_json_response(
+          expected_json(
+            binding_guid: VCAP::CloudController::RouteBinding.first.guid,
+            service_instance_guid: service_instance.guid,
+            route_guid: route.guid,
+          )
+        )
       end
 
       describe 'permissions' do
@@ -278,4 +279,35 @@
     space.add_developer(user)
     headers_for(user)
   end
+
+  def expected_json(binding_guid:, route_guid:, service_instance_guid:)
+    {
+      guid: binding_guid,
+      created_at: iso8601,
+      updated_at: iso8601,
+      relationships: {
+        service_instance: {
+          data: {
+            guid: service_instance_guid
+          }
+        },
+        route: {
+          data: {
+            guid: route_guid
+          }
+        }
+      },
+      links: {
+        self: {
+          href: "#{link_prefix}/v3/service_route_bindings/#{binding_guid}"
+        },
+        service_instance: {
+          href: "#{link_prefix}/v3/service_instances/#{service_instance_guid}"
+        },
+        route: {
+          href: "#{link_prefix}/v3/routes/#{route_guid}"
+        }
+      }
+    }
+  end
 end

spec/unit/presenters/v3/service_route_binding_presenter_spec.rb

@@ -0,0 +1,55 @@
+require 'spec_helper'
+require 'presenters/v3/service_route_binding_presenter'
+
+module VCAP
+  module CloudController
+    RSpec.describe Presenters::V3::ServiceRouteBindingPresenter do
+      let(:space) { VCAP::CloudController::Space.make }
+      let(:route_service_url) { 'https://route_service_url.com' }
+      let(:service_instance) { VCAP::CloudController::UserProvidedServiceInstance.make(space: space, route_service_url: route_service_url) }
+      let(:route) { Route.make(space: space) }
+      let(:guid) { Sham.guid }
+      let(:binding) do
+        RouteBinding.make(
+          guid: guid,
+          service_instance: service_instance,
+          route: route,
+        )
+      end
+
+      it 'presents the correct object' do
+        presenter = described_class.new(binding)
+        expect(presenter.to_hash).to match(
+          {
+            guid: guid,
+            created_at: binding.created_at,
+            updated_at: binding.updated_at,
+            relationships: {
+              route: {
+                data: {
+                  guid: route.guid
+                }
+              },
+              service_instance: {
+                data: {
+                  guid: service_instance.guid
+                }
+              }
+            },
+            links: {
+              self: {
+                href: %r{.*/v3/service_route_bindings/#{guid}}
+              },
+              route: {
+                href: %r{.*/v3/routes/#{route.guid}}
+              },
+              service_instance: {
+                href: %r{.*/v3/service_instances/#{service_instance.guid}}
+              }
+            }
+          }
+        )
+      end
+    end
+  end
+end