v3(services): add common filters to service credential bindings

[#175686797](https://www.pivotaltracker.com/story/show/175686797)

Author: pivotal-marcela-campo

app/controllers/v3/service_credential_bindings_controller.rb

@@ -294,7 +294,7 @@ def binding_org
   end
 
   def list_fetcher
-    @list_fetcher ||= VCAP::CloudController::ServiceCredentialBindingListFetcher.new
+    @list_fetcher ||= VCAP::CloudController::ServiceCredentialBindingListFetcher
   end
 
   def fetcher

app/fetchers/service_credential_binding_fetcher.rb

@@ -10,7 +10,7 @@ def fetch(guid, space_guids:)
       private
 
       def list_fetcher
-        ServiceCredentialBindingListFetcher.new
+        ServiceCredentialBindingListFetcher
       end
     end
   end

app/fetchers/service_credential_binding_list_fetcher.rb

@@ -1,59 +1,63 @@
+require 'fetchers/base_list_fetcher'
+
 module VCAP
   module CloudController
-    class ServiceCredentialBindingListFetcher
-      def fetch(space_guids:, message: nil)
-        dataset = case space_guids
-                  when :all
-                    ServiceCredentialBinding::View.dataset
-                  else
-                    ServiceCredentialBinding::View.where { Sequel[:space_guid] =~ space_guids }
-                  end
-
-        return dataset if message.nil?
-
-        apply_filters(dataset, message)
-      end
+    class ServiceCredentialBindingListFetcher < BaseListFetcher
+      class << self
+        FILTERABLE_PROPERTIES = %w{
+          service_instance_name
+          service_instance_guid
+          name
+          app_name
+          app_guid
+          type
+          service_plan_name
+          service_plan_guid
+          service_offering_name
+          service_offering_guid
+        }.freeze
+
+        def fetch(space_guids:, message: nil)
+          dataset = case space_guids
+                    when :all
+                      ServiceCredentialBinding::View.dataset
+                    else
+                      ServiceCredentialBinding::View.where { Sequel[:space_guid] =~ space_guids }
+                    end
 
-      private
+          return dataset if message.nil?
 
-      def apply_filters(dataset, message)
-        filters_from_message(message).each do |f|
-          dataset = dataset.where { f }
+          filter(dataset, message)
         end
 
-        dataset
-      end
+        private
 
-      FILTERABLE_PROPERTIES = %w{
-        service_instance_name
-        service_instance_guid
-        name
-        app_name
-        app_guid
-        type
-        service_plan_name
-        service_plan_guid
-        service_offering_name
-        service_offering_guid
-      }.freeze
-
-      def filters_from_message(message)
-        FILTERABLE_PROPERTIES.
-          select { |property| message.requested?(message_param_for(property)) }.
-          reduce([]) { |clauses, property| clauses << build_where_clause(message, property) }
-      end
+        def filter(dataset, message)
+          filters_from_message(message).each do |f|
+            dataset = dataset.where { f }
+          end
 
-      def build_where_clause(message, field)
-        message_param = message_param_for(field)
-        Sequel[field.to_sym] =~ message.public_send(message_param)
-      end
+          super(message, dataset, ServiceCredentialBinding::View)
+        end
+
+        def filters_from_message(message)
+          FILTERABLE_PROPERTIES.
+            select { |property| message.requested?(message_param_for(property)) }.
+            reduce([]) { |clauses, property| clauses << build_where_clause(message, property) }
+        end
+
+        def build_where_clause(message, field)
+          message_param = message_param_for(field)
+          Sequel[field.to_sym] =~ message.public_send(message_param)
+        end
 
-      def message_param_for(field)
-        case field
-        when 'type'
-          :type
-        else
-          field.pluralize.to_sym
+        def message_param_for(field)
+          case field
+          when 'type'
+            :type
+          else
+            field.pluralize.to_sym
+          end
         end
       end
     end

docs/v3/source/includes/experimental_resources/service_credential_bindings/_list.md.erb

@@ -41,6 +41,9 @@ Name | Type | Description
 **service_offering_guids** | _list of strings_ | Comma-delimited list of service offering guids to filter by
 **service_offering_names** | _list of strings_ | Comma-delimited list of service offering names to filter by
 **type** | _list of strings_ | Type of credential binding to filter by. Valid values are: `app` or `key`
+**guids** | _list of strings_ | Comma-delimited list of service route binding guids to filter by
+**created_ats** (*experimental*)| _[timestamp](#timestamps)_ | Timestamp to filter by. When filtering on equality, several comma-delimited timestamps may be passed. Also supports filtering with [relational operators](#relational-operators-experimental)
+**updated_ats** (*experimental*)| _[timestamp](#timestamps)_ | Timestamp to filter by. When filtering on equality, several comma-delimited timestamps may be passed. Also supports filtering with [relational operators](#relational-operators-experimental)
 **include** | _list of strings_ | Optionally include a list of unique related resources in the response. Valid values are: `app`, `service_instance`
 **page** | _integer_ | Page to display; valid values are integers >= 1
 **per_page** | _integer_ | Number of results per page; <br>valid values are 1 through 5000

spec/request/service_credential_bindings_spec.rb

@@ -113,6 +113,22 @@
       end
 
       describe 'filters' do
+        it_behaves_like 'list_endpoint_with_common_filters' do
+          let(:resource_klass) { VCAP::CloudController::ServiceBinding }
+          let(:api_call) do
+            lambda { |headers, filters| get "/v3/service_credential_bindings?#{filters}", nil, headers }
+          end
+          let(:headers) { admin_headers }
+        end
+
+        it_behaves_like 'list_endpoint_with_common_filters' do
+          let(:resource_klass) { VCAP::CloudController::ServiceKey }
+          let(:api_call) do
+            lambda { |headers, filters| get "/v3/service_credential_bindings?#{filters}", nil, headers }
+          end
+          let(:headers) { admin_headers }
+        end
+
         let(:some_instance) { VCAP::CloudController::ManagedServiceInstance.make(space: space) }
         let!(:another_key) { VCAP::CloudController::ServiceKey.make(service_instance: some_instance) }
         let!(:another_binding) { VCAP::CloudController::ServiceBinding.make(service_instance: some_instance) }

spec/unit/fetchers/service_credential_binding_list_fetcher_spec.rb

@@ -7,7 +7,7 @@ module CloudController
     RSpec.describe ServiceCredentialBindingListFetcher do
       let(:params) { {} }
       let(:message) { ServiceCredentialBindingListMessage.from_params(params) }
-      let(:fetcher) { ServiceCredentialBindingListFetcher.new }
+      let(:fetcher) { described_class }
 
       describe 'no bindings' do
         it 'returns an empty result' do