Users with URL unsafe characters in guids do not cause unknown errors

when being presented

* same fix as 9997811 but for links
in the roles endpoints

[finishes #172744797]

Co-authored-by: Reid Mitchell <rmitchell@pivotal.io>
Co-authored-by: Mona Mohebbi <mmohebbi@pivotal.io>

Author: reidmit

app/presenters/v3/role_presenter.rb

@@ -26,7 +26,7 @@ def build_links
           href: url_builder.build_url(path: "/v3/roles/#{role.guid}"),
         },
         user: {
-          href: url_builder.build_url(path: "/v3/users/#{role.user_guid}"),
+          href: url_builder.build_url(path: "/v3/users/#{CGI.escape(role.user_guid)}"),
         },
       }
       if VCAP::CloudController::RoleTypes::SPACE_ROLES.include? role.type

spec/unit/presenters/v3/role_presenter_spec.rb

@@ -125,6 +125,16 @@ module VCAP::CloudController::Presenters::V3
           expect(result[:links][:organization][:href]).to eq("#{link_prefix}/v3/organizations/#{role.organization.guid}")
         end
       end
+
+      describe 'when the user guid is weird' do
+        let(:user) { VCAP::CloudController::User.make(guid: ':---)') }
+        let(:role) { VCAP::CloudController::SpaceAuditor.make(user: user) }
+        let(:result) { presenter.to_hash }
+
+        it 'presents the role' do
+          expect(result[:links][:user][:href]).to eq("#{link_prefix}/v3/users/#{CGI.escape(role.user_guid)}")
+        end
+      end
     end
   end
 end