Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions transformers/tables.go
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,9 @@ func TransformTables(tables schema.Tables) error {
if err := TransformTables(table.Relations); err != nil {
return err
}
if len(table.PrimaryKeys()) > 0 && len(table.PrimaryKeyComponents()) > 0 {
return fmt.Errorf("primary keys and primary key components cannot both be set for table %q", table.Name)
}
}
return nil
}
Expand Down
27 changes: 27 additions & 0 deletions transformers/tables_test.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
package transformers

import (
"testing"

"github.com/apache/arrow-go/v18/arrow"
"github.com/cloudquery/plugin-sdk/v4/schema"
"github.com/stretchr/testify/require"
)

func TestTransformTablesErrorOnPKFieldsAndPKComponentFields(t *testing.T) {
type testStructWithPKComponent struct {
ID int `json:"id"`
Name string `json:"name"`
}

testTable := &schema.Table{
Name: "test",
Transform: TransformWithStruct(testStructWithPKComponent{}, WithPrimaryKeys("id")),
Columns: []schema.Column{
{Name: "name", Type: arrow.BinaryTypes.String, PrimaryKeyComponent: true},
},
}

err := TransformTables([]*schema.Table{testTable})
require.Error(t, err, "primary keys and primary key components cannot both be set for table \"test\"")
}
Loading