feat: Add source plugin version to table metadata.#2370
Closed
marianogappa wants to merge 1 commit intomainfrom
Closed
feat: Add source plugin version to table metadata.#2370marianogappa wants to merge 1 commit intomainfrom
marianogappa wants to merge 1 commit intomainfrom
Conversation
erezrokah
reviewed
Dec 16, 2025
Member
erezrokah
left a comment
erezrokah
left a comment
There was a problem hiding this comment.
Maybe I'm missing something but isn't it guaranteed that the tables we process are pinned to a specific known plugin version?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds source plugin version as table metadata via Arrow metadata in
MigrateTablemessages and in theTablestruct.Versioning information is useful in this entity, because table name is insufficient to fully define what the contents of the table would be.
I checked the proto repos, and it seems that the
Tableentity is marshalled/unmarshalled as bytes, so adding a property to it only requires changes in this repo, but correct me if I'm wrong.A subsequent PR (not in this repo) will persist this information in the Parquet writer, which supports file metadata.