Use cfg_select! for conditional compilation based on target_feature#895
Open
jgilchrist wants to merge 1 commit intocodedeliveryservice:mainfrom
Open
Use cfg_select! for conditional compilation based on target_feature#895jgilchrist wants to merge 1 commit intocodedeliveryservice:mainfrom
jgilchrist wants to merge 1 commit intocodedeliveryservice:mainfrom
Conversation
jgilchrist
force-pushed
the
use-cfg_select
branch
6 times, most recently
from
e644c9b to
36f6c24
Compare
Ups the Rust requirement to 1.95, so may be a while before this could be merged. But is a _much_ nicer way of expressing this pattern.
jgilchrist
force-pushed
the
use-cfg_select
branch
from
36f6c24 to
f0c1016
Compare
jgilchrist
commented
Apr 16, 2026
| ft_out: &Aligned<[u8; L1_SIZE]>, nnz_table: &[SparseEntry], | ||
| ) -> (Aligned<[u16; L1_SIZE / 4]>, usize) { | ||
| use std::arch::x86_64::*; | ||
| cfg_select! { |
Author
There was a problem hiding this comment.
Definitely an argument that it's trickier to read for these larger functions, so will revert if others agree
jgilchrist
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ups the Rust requirement to 1.95, so may be a while before this could be merged. But is a much nicer way of expressing this pattern.