ci: specify junit.xml path for Codecov test results upload#1943
Closed
bearomorphism wants to merge 1 commit intomasterfrom
Closed
ci: specify junit.xml path for Codecov test results upload#1943bearomorphism wants to merge 1 commit intomasterfrom
bearomorphism wants to merge 1 commit intomasterfrom
Conversation
The 'Upload test results to Codecov' step was failing with 'No JUnit XML reports found' because the codecov-action could not auto-discover the file. The poe 'cover' task generates junit.xml in the project root via --junitxml=junit.xml, so we explicitly set file: junit.xml. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1943 +/- ##
=======================================
Coverage 98.10% 98.10%
=======================================
Files 61 61
Lines 2748 2748
=======================================
Hits 2696 2696
Misses 52 52 ☔ View full report in Codecov by Sentry. |
Collaborator
Author
|
Closing - the CI failure was caused by a mypy overload error (now fixed in PR #1941), not a Codecov auto-discovery issue. The JUnit XML was missing because tests never ran due to the lint failure. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The "Upload test results to Codecov" step in CI intermittently fails with:
The poe
covertask (run viapoe ci) generatesjunit.xmlin the project root (--junitxml=junit.xmlin pyproject.toml line 299), but thecodecov/codecov-action@v6withreport_type: test_resultsrelies on auto-discovery which is unreliable.Fix
Add
file: junit.xmlto explicitly point the Codecov action at the generated JUnit XML report.Evidence of flaky behavior
Same branch, same workflow, same step — different outcomes:
Both runs executed the same workflow without
file:specified. The Codecov CLI auto-discovery foundjunit.xmlin one run but not the other. Adding an explicit path eliminates this non-determinism.Checklist
Was generative AI tooling used to co-author this PR?
Generated-by: GitHub Copilot CLI