init: fix FreeBSD build by guarding tmpfs mount with __linux__#666
Open
mtjhrc wants to merge 1 commit intocontainers:mainfrom
Open
init: fix FreeBSD build by guarding tmpfs mount with __linux__#666mtjhrc wants to merge 1 commit intocontainers:mainfrom
mtjhrc wants to merge 1 commit intocontainers:mainfrom
Conversation
mtjhrc
requested review from
MatiasVara,
dorindabassey,
jakecorrenti,
slp and
tylerfanelli
as code owners
The tmpfs mount added in 536360a uses Linux-specific MS_* flags and the Linux mount() signature, which don't exist on FreeBSD. Guard the block with #if __linux__ to fix the FreeBSD cross-compilation. Signed-off-by: Matej Hrica <mhrica@redhat.com>
mtjhrc
force-pushed
the
fix-freebsd-init-build
branch
from
1ecf459 to
3c9682d
Compare
Contributor
|
FWIW LGTM and thanks for the fix 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
init: Mount a tmpfs if requested) uses Linux-specificMS_NOEXEC/MS_NOSUID/MS_NODEV/MS_RELATIMEflags and the Linuxmount()signature, which don't exist on FreeBSD.#if __linux__to fix the FreeBSD cross-compilation that's currently breaking CI.Fixes the
init/init-freebsdbuild error: