utils.h: reject unexpected preceding characters in strToInt()#8490
Merged
firewave merged 5 commits intocppcheck-opensource:mainfrom Apr 26, 2026
Merged
utils.h: reject unexpected preceding characters in strToInt()#8490firewave merged 5 commits intocppcheck-opensource:mainfrom
strToInt()#8490firewave merged 5 commits intocppcheck-opensource:mainfrom
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
danmar
reviewed
Apr 26, 2026
| *err = "needs to be positive"; | ||
| return false; | ||
| } | ||
| if (str.front() != '+' && isdigit(str.front()) == 0) { |
Collaborator
There was a problem hiding this comment.
I don't have good reasons but personally I would prefer !
Suggested change
| if (str.front() != '+' && isdigit(str.front()) == 0) { | |
| if (str.front() != '+' && !isdigit(str.front())) { |
== 0 is a bit like misleading somehow..
Collaborator
Author
There was a problem hiding this comment.
That was my original code but it produces a Cppcheck Premium warning because you check an integer result with !.
danmar
approved these changes
Apr 26, 2026
Collaborator
danmar
left a comment
danmar
left a comment
There was a problem hiding this comment.
I just have a little nit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.