This repository was archived by the owner on Jan 7, 2022. It is now read-only.
Make sure to populate the multidat error back up the stack#3
Open
okdistribute wants to merge 1 commit intomasterfrom
Open
Make sure to populate the multidat error back up the stack#3okdistribute wants to merge 1 commit intomasterfrom
okdistribute wants to merge 1 commit intomasterfrom
Conversation
Collaborator
|
The error is still being propagated; if you look at the stack trace it should be clear (: Also: I wasn't aware module mismatch errors were handled through a callback; I would've assumed they threw? That seems like a rather odd use of callbacks imo |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was getting a module mismatch error but it was hidden under the sheets. I think in general it's nice to propagate fatal errors like this up the stack