Skip to content

[Bug]: Eliminate forced reflow during carousel initialization #1327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dlabadini wants to merge 1 commit into
base: master
Choose a base branch
from
+7 −4
Open

[Bug]: Eliminate forced reflow during carousel initialization #1327

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions packages/embla-carousel/src/components/EmblaCarousel.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,18 +134,20 @@ function EmblaCarousel(
if (!options.active) return

if (!isSsr && ownerWindow) {
engine.resizeHandler.init(ownerWindow)
const containerVisible = container.offsetParent

engine.translate.to(engine.location)
engine.scrollOptimizer.optimize(true)
if (engine.options.loop) engine.slideLooper.loop()

engine.animation.init(ownerWindow)
engine.resizeHandler.init(ownerWindow)
engine.slidesInView.init(ownerWindow)
engine.slidesHandler.init(ownerWindow)
engine.slideFocus.init(ownerWindow)
engine.eventHandler.init(self)

if (container.offsetParent && slides.length) {
if (containerVisible && slides.length) {
engine.dragHandler.init(ownerWindow)
}
}
Expand Down
5 changes: 3 additions & 2 deletions packages/embla-carousel/src/components/NodeHandler.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,12 +64,13 @@ export function NodeHandler(root: HTMLElement): NodeHandlerType {

const containerStyle = root ? container.style : { transform: '' }
const previousTransform = containerStyle.transform
containerStyle.transform = 'none'
const needsReset = previousTransform && previousTransform !== 'none'
if (needsReset) containerStyle.transform = 'none'

const containerRect = getRect(container)
const slideRects = slides.map(getRect)

containerStyle.transform = previousTransform
if (needsReset) containerStyle.transform = previousTransform
rects = { containerRect, slideRects }
return rects
}
Expand Down