Add Support for "Nice Names" for Windows Network Interfaces#473
Open
doadin wants to merge 1 commit intodeluge-torrent:developfrom
Open
Add Support for "Nice Names" for Windows Network Interfaces#473doadin wants to merge 1 commit intodeluge-torrent:developfrom
doadin wants to merge 1 commit intodeluge-torrent:developfrom
Conversation
doadin
force-pushed
the
develop-winifaddrname
branch
from
eb2e8a8 to
743b17a
Compare
doadin
force-pushed
the
develop-winifaddrname
branch
from
743b17a to
f941fb2
Compare
doadin
force-pushed
the
develop-winifaddrname
branch
from
f941fb2 to
9efcb8d
Compare
doadin
force-pushed
the
develop-winifaddrname
branch
from
9efcb8d to
8566d8e
Compare
Contributor
Author
|
@cas-- Anything I can do to make this acceptable? Edit: maybe convert_win_ifaddr_nice_name_to_name should be something like find_guid_from_win_ifaddr_nice_name still way long but idk how else to shorten it and still know what its doing. |
Contributor
Author
|
@cas-- I know the same comment I made before probabbly still stands but something I also thought about before and is maybe a change for a different PR. Currently deluge falls back to a previous config value for network interface if it has issues. I think instead to avoid IP leaks etc it should default to 127.0.0.1 to prevent connections. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.