fix: declare selenium-java as provided scope in selenium module#577
Draft
scottmries wants to merge 1 commit intodevelopfrom
Draft
fix: declare selenium-java as provided scope in selenium module#577scottmries wants to merge 1 commit intodevelopfrom
scottmries wants to merge 1 commit intodevelopfrom
Conversation
|
|
There was a problem hiding this comment.
Pull request overview
This PR updates the selenium Maven module to stop bundling Selenium/WebDriverManager transitively, letting downstream consumers control their Selenium dependency version to avoid conflicts (per Issue #576).
Changes:
- Set
org.seleniumhq.selenium:selenium-javatoprovidedscope in theseleniummodule. - Remove the
io.github.bonigarcia:webdrivermanagerdependency from theseleniummodule. - Update
selenium/README.mdinstallation guidance to describe Selenium as a peer dependency and refresh version examples.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
selenium/pom.xml |
Changes Selenium dependency scope to provided and removes WebDriverManager. |
selenium/README.md |
Updates installation instructions to reflect the new dependency expectations. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
straker
previously approved these changes
Mar 24, 2026
Garbee
requested changes
Mar 24, 2026
Member
Garbee
left a comment
Garbee
left a comment
There was a problem hiding this comment.
Just blocking until we discuss breaking change impact. Once that is resolved, this should be fine to go once adjusted (if needed) to merge based on that discussion.
Explains that consumers can declare their own selenium-java version and Maven will use it instead of the transitive dependency. Also fixes typo "Seleium" -> "Selenium".
scottmries
force-pushed
the
fix/selenium-provided-scope
branch
from
d31b839 to
7dba71a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes selenium-java and webdrivermanager as transitive dependencies so consumers can manage their own Selenium version without conflicts. Also removes unused webdrivermanager dependency.
Issue: #576