Skip to content

Remove transitive dependency sqlparse from example/requirements.txt#1285

Closed
vtalos wants to merge 1 commit intodjango-json-api:mainfrom
vtalos:remove-transitive-sqlparse
Closed

Remove transitive dependency sqlparse from example/requirements.txt#1285
vtalos wants to merge 1 commit intodjango-json-api:mainfrom
vtalos:remove-transitive-sqlparse

Conversation

@vtalos
Copy link
Copy Markdown

@vtalos vtalos commented Jul 17, 2025

Fixes #1284

Description of the Change

As part of our ongoing research on Python dependency management we noticed a potential improvement in your project’s dependency management.

Specifically, the transitive dependency sqlparse, which is required by Django, is specified as a requirement in the example/requirements.txt file, even though it is not used directly and does not need to be listed explicitly.

This PR removes it from example/requirements.txt to let pip manage it automatically, which helps keeping the dependency list clean.

Hope this is helpful!

Checklist

  • PR only contains one change (considered splitting up PR)
  • unit-test added
  • documentation updated
  • CHANGELOG.md updated (only for user relevant changes)
  • author name in AUTHORS

@sliverc
Copy link
Copy Markdown
Member

sliverc commented Jul 17, 2025

Thanks for the hinter. Actually, the example/requirements.txt file is obsolete and is not referenced anywhere or used at this point. Therefore, example/requirements.txt can be completely removed, as the requirements.txt in the root folder is the correct one and referenced in the README,

@sliverc
Copy link
Copy Markdown
Member

sliverc commented Jul 18, 2025

Super seeded by #1287 therefore closing. Thanks for your initial hinter.

@sliverc sliverc closed this Jul 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove transitive dependency sqlparse from example/requirements.txt

2 participants